Parse const unsafe trait properly
#147864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No reviewers could be found from initial request |
rustbot
added
S-waiting-on-review
Previously, this was greedily stolen by the `fn` parsing logic.
rust-cloud-vms
bot
force-pushed
the
consttraitparse
branch
from
1603311 to
b145213
Compare
|
r? fmease |
|
cc #146122 |
|
I quite agree with your comment at #146122 (comment) |
fmease
approved these changes
Oct 19, 2025
|
Thanks! This is good enough for now. I'm already experimenting with more robust+principled qualifier parsing in a separate project of mine. Once stage0 rustfmt is bumped we can finally migrate away from the remaining @bors r+ rollup |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 19, 2025
… r=fmease Parse `const unsafe trait` properly Previously, this was greedily stolen by the `fn` parsing logic. r? project-const-traits
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 19, 2025
… r=fmease Parse `const unsafe trait` properly Previously, this was greedily stolen by the `fn` parsing logic. r? project-const-traits
rust-timer
added a commit
that referenced
this pull request
Oct 19, 2025
Rollup merge of #147864 - fee1-dead-contrib:consttraitparse, r=fmease Parse `const unsafe trait` properly Previously, this was greedily stolen by the `fn` parsing logic. r? project-const-traits
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Oct 20, 2025
Rollup of 4 pull requests Successful merges: - rust-lang/rust#147575 (Refactor move analysis subpath representation) - rust-lang/rust#147864 (Parse `const unsafe trait` properly) - rust-lang/rust#147868 (MirPatch: Simplify new_local.) - rust-lang/rust#147873 (comments for deduce_param_attrs) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this was greedily stolen by the
fnparsing logic.r? project-const-traits